search

schwehr / libais

C++ decoder for Automatic Identification System for tracking ships and decoding maritime information
Other
215 stars 94 forks source link

Add code to parse 8:367:24 message. #220

Closed andyvan-trabus closed 2 years ago

andyvan-trabus commented 2 years ago

This is the smallest message.

andyvan-trabus commented 2 years ago

I'm sorry, but I'm unclear as to the next step. I believe I've addressed all of the review comments, and I've merged in changes that other people have made to this branch (why?).

schwehr commented 2 years ago

I'm sorry, but I'm unclear as to the next step. I believe I've addressed all of the review comments, and I've merged in changes that other people have made to this branch (why?).

Apologies! I missed hitting finish on the review button. I do 99.9% of my code reviews outside of github.

The key thing that needs to happen is removing the code related to the non-compliant messages. Devices sending bad messages should be fix or retired. If someone is looking for deep bit inspection, then using things like noaadata + bitvector is more appropriate.

schwehr commented 2 years ago

Build failure:

build/temp.linux-x86_64-3.8/src/libais/ais8_366.o -std=c++11
    g++-6 -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -I/opt/hostedtoolcache/Python/3.8.11/x64/include/python3.8 -c src/libais/ais8_367.cpp -o build/temp.linux-x86_64-3.8/src/libais/ais8_367.o -std=c++11
    src/libais/ais8_367.cpp:168:27: error: definition of implicitly-declared ‘virtual libais::Ais8_367_22::~Ais8_367_22()’
     Ais8_367_22::~Ais8_367_22() {
                               ^
    error: command 'g++-6' failed with exit status 1
    ----------------------------------------
ERROR: Command errored out with exit status 1: /opt/hostedtoolcache/Python/3.8.11/x64/bin/python -u -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-req-build-volbnmpd/setup.py'"'"'; __file__='"'"'/tmp/pip-req-build-volbnmpd/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /tmp/pip-record-lxm1sy9r/install-record.txt --single-version-externally-managed --compile --install-headers /opt/hostedtoolcache/Python/3.8.11/x64/include/python3.8/libais Check the logs for full command output.
andyvan-trabus commented 2 years ago

Okay, I think I've made all of the requested changes. And, I wasn't being snarky, I'm not sure of the workflow here. Once I push a commit with the changes, is there anything else I need to do to keep this moving?

schwehr commented 2 years ago

Okay, I think I've made all of the requested changes. And, I wasn't being snarky, I'm not sure of the workflow here. Once I push a commit with the changes, is there anything else I need to do to keep this moving?

I didn't see any snark. I'm not totally sure of the workflow either... sigh. The change looks good to me. Thanks for sticking with it!