search

schwehr / libais

C++ decoder for Automatic Identification System for tracking ships and decoding maritime information
Other
215 stars 94 forks source link

Add parsing for 8_367_33. #242

Closed andyvan-trabus closed 2 years ago

andyvan-trabus commented 2 years ago

This was a lot more work, thanks for the suggestion to work my way up to it.

I did make 1 change that I think you might push back against. I ran cppcheck on the new files, and I was getting warnings about missing assignments in the base AisMsg class. I added them in to eliminate the warnings in the new files.

schwehr commented 2 years ago

This was a lot more work, thanks for the suggestion to work my way up to it.

I did make 1 change that I think you might push back against. I ran cppcheck on the new files, and I was getting warnings about missing assignments in the base AisMsg class. I added them in to eliminate the warnings in the new files.

Those cppcheck fixes are correct to initialize ints and floats.

andyvan-trabus commented 2 years ago

Okay, I think this is ready to go.