search

schweikert / fping

High performance ping tool
https://fping.org
Other
1.01k stars 250 forks source link

Options "-c N" / "-C N" versus "-a" and "-u" #296

Closed auerswal closed 7 months ago

auerswal commented 7 months ago
  1. Adjust fping -h output to emphasize that -c N changes the output format.
  2. Adjust fping -h output to emphasize that -i MSEC does not change the output format.
  3. Ensure that neither -a nor -u affect -c N resp. -C N operation, and test this.
  4. Document in the man page that -c N and -C N override -a or -u.

This addresses issue #295. It should also help at least somewhat with issues #271 and #274.

coveralls commented 7 months ago

Coverage Status

coverage: 82.435% (-0.2%) from 82.67% when pulling 1bf041bb12107822e59ffca0f29cf25811b18bf1 on auerswal:c_vs_a_and_u into 290d944b56d78bf83cce54562707a605c56b442b on schweikert:develop.

auerswal commented 7 months ago

Again I'd say that the reportedly reduced coverage is a bogus result. The pull request moves existing code around. All of the code was already tested (even though the observable output of combining -c N or -C N with either -a or -u was not), and as such the code coverage does not really change. Please consider merging anyway. Thanks in advance!

auerswal commented 7 months ago

I close this PR, then open a new one.