search

schweikert / fping

High performance ping tool
https://fping.org
Other
1.01k stars 250 forks source link

Options "-c N" / "-C N" versus "-a" and "-u" (v2) #298

Closed auerswal closed 6 months ago

auerswal commented 7 months ago
  1. Adjust fping -h output to emphasize that -i MSEC does not change the output format.
  2. Ensure that neither -a nor -u affect -c N resp. -C N operation, and test this.
  3. Document in the man page that -c N and -C N override -a or -u.

This addresses issue #295. It should also help at least somewhat with issues #271 and #274.

coveralls commented 7 months ago

Coverage Status

coverage: 84.191% (-0.2%) from 84.423% when pulling 818821f0c5723c3f874d669da0b4b4927587fdf7 on auerswal:c_vs_a_and_u-v2 into d312a278d5a51c4950b27a4c3bbe3ae888eef4d8 on schweikert:develop.

auerswal commented 7 months ago

Again I'd say that the reportedly reduced coverage is a bogus result. The pull request moves existing code around. All of the code was already tested (even though the observable output of combining -c N or -C N with either -a or -u was not), and as such the code coverage does not really change. Please consider merging anyway. Thanks in advance!

auerswal commented 7 months ago

I would like to adjust the fping -h output regarding both -c N and -C N a bit, without changing their positions:

Current:

   -c, --count=N      count mode: send N pings to each target
   -C, --vcount=N     same as -c, report results in verbose format

Suggestion:

   -c, --count=N      count mode: send N pings to each target and report stats
   -C, --vcount=N     same as -c, report results (not stats) in verbose format

Is this OK? If yes, I can add this as another commit to this pull request before you merge.

schweikert commented 6 months ago

I would like to adjust the fping -h output regarding both -c N and -C N a bit, without changing their positions:

Current:

   -c, --count=N      count mode: send N pings to each target
   -C, --vcount=N     same as -c, report results in verbose format

Suggestion:

   -c, --count=N      count mode: send N pings to each target and report stats
   -C, --vcount=N     same as -c, report results (not stats) in verbose format

Is this OK? If yes, I can add this as another commit to this pull request before you merge.

Sounds good to me. Thank you!

auerswal commented 6 months ago

Thanks!