Closed auerswal closed 6 months ago
Again I'd say that the reportedly reduced coverage is a bogus result. The pull request moves existing code around. All of the code was already tested (even though the observable output of combining -c N or -C N with either -a or -u was not), and as such the code coverage does not really change. Please consider merging anyway. Thanks in advance!
I would like to adjust the fping -h
output regarding both -c N
and -C N
a bit, without changing their positions:
Current:
-c, --count=N count mode: send N pings to each target
-C, --vcount=N same as -c, report results in verbose format
Suggestion:
-c, --count=N count mode: send N pings to each target and report stats
-C, --vcount=N same as -c, report results (not stats) in verbose format
Is this OK? If yes, I can add this as another commit to this pull request before you merge.
I would like to adjust the
fping -h
output regarding both-c N
and-C N
a bit, without changing their positions:Current:
-c, --count=N count mode: send N pings to each target -C, --vcount=N same as -c, report results in verbose format
Suggestion:
-c, --count=N count mode: send N pings to each target and report stats -C, --vcount=N same as -c, report results (not stats) in verbose format
Is this OK? If yes, I can add this as another commit to this pull request before you merge.
Sounds good to me. Thank you!
Thanks!
This addresses issue #295. It should also help at least somewhat with issues #271 and #274.