search

schweikert / fping

High performance ping tool
https://fping.org
Other
1.01k stars 250 forks source link

Print cumulative stats with -Q SECS,cumulative #315

Closed auerswal closed 4 months ago

auerswal commented 4 months ago

With -Q SECS, fping emits information for the just finished interval. This is good for long-running fping processes where one would like to get an update on recent results, ignoring missing responses from older intervals. This seems appropriate for use with other software like netdata or smokeping.

But for short(er)-running fping processes, e.g., during a change window, it may be more interesting to get a status update since the beginning of the change window, i.e., the start of fping. Adding a comma followed by the keyword "cumulative" to -Q SECS (i.e., -Q SECS,cumulative) changes the interim reports to output the current per system overall statistics, unless -N is used, too.

The new syntax is documented in fping.pod and added to fping -h output.

Four tests are added:

  1. Characters after SECS are ignored as before.
  2. Unknown keywords are ignored as before.
  3. Adding ",cumulative" changes -Q output.
  4. Adding ",cumulative" also affects the additional -o output.

This addresses issue #243.

coveralls commented 4 months ago

Coverage Status

coverage: 84.886% (+0.1%) from 84.768% when pulling 62e60b5c44715650d258a11d9147aa36251fe54d on auerswal:cumulative_stats into 0d08321346164487464bd2910b323314d5607219 on schweikert:develop.

auerswal commented 3 months ago

Thanks!