schweikert / fping

High performance ping tool
https://fping.org
Other
1.01k stars 250 forks source link

ci: skip an unreliable test on macOS #328

Closed auerswal closed 2 months ago

auerswal commented 2 months ago

Sometimes, this test fails on macOS, at least on the GitHub CI. It looks as if the fping process is killed before it produces the required output. This test works reliably on GNU/Linux, so keep it, but skip it when running on macOS.

coveralls commented 2 months ago

Coverage Status

coverage: 85.622% (+0.2%) from 85.469% when pulling 56bd3d8aacc5738cd0c1e3e72ff52b7f17d90d1c on auerswal:ci_reliability into 94de79153f1d14ba0385037202fd0e5e5a6f7b5b on schweikert:develop.

gsnw commented 2 months ago

I use Azure Devops with macOS and have no problem with ci/test-07-options-i-m.pl. We should investigate why this happens with Github Action via a ticket if necessary

auerswal commented 2 months ago

I have no experience with macOS except for the fping GitHub CI. The macOS tests on this GitHub CI have proven problematic in the past, where I had to adjust the timing of tests to make them work. Since I have seen some failures for this test, but have also seen it succeed (re-running the failed tests usually makes it pass), I would prefer not to have to look at those spurious test failures.

I would expect the problem to be caused by high load on the test runners.

I do not have the motivation to find out if there is any support regarding the CI infrastructure and, if it exists, if it is useful.

@gsnw: Do you know a way to skip this test only on the GitHub CI, but not on Azure DevOps?

gsnw commented 2 months ago

You can merge this pull-request. I have create a new issue.