search

schweikert / fping

High performance ping tool
https://fping.org
Other
1.01k stars 250 forks source link

Print returned TOS value #335

Closed gsnw closed 1 month ago

gsnw commented 1 month ago

Added tos to the header again, but only for IPv4. IPv6 uses ds field here Currently, TOS is only output in one place as in the ticket example.

Issue #68

coveralls commented 1 month ago

Coverage Status

coverage: 85.512% (+0.05%) from 85.46% when pulling 3798851be5ba36d57a0306047c16e1bee25ebd0a on gsnw:issue/68 into 8ecda7f0cd9610424140815c5591bb8d73861851 on schweikert:develop.

auerswal commented 1 month ago

I like the general approach of using an option to enable printing of received TOS values. I also like to approach of starting with the default output (<target> is alive (TOS <value>)).

gsnw commented 1 month ago

I have changed the logic a bit and --print-tos can be used independently of the -O parameter. However, it is only displayed if the value is present in the IP header.

gsnw-sebast commented 1 month ago

Perfect, can you merge that please? I made a few changes to my github account and lost my permissions as a result