schweikert / postgrey

Postfix Greylisting Policy-Daemon
https://postgrey.schweikert.ch/
GNU General Public License v2.0
161 stars 48 forks source link

Sorted hostnames alphabetically + Whitelist some large pool #104

Open frugan-dev opened 8 months ago

frugan-dev commented 8 months ago

@schweikert Wouldn't it be a good idea to sort the records alphabetically, to make the file more readable?

fleish commented 7 months ago

I personally prefer it to be sorted chronologically. You can always pass it through sort to see it alphabetically if you want.

frugan-dev commented 7 months ago

@fleish well.. we're using git: it handles the history!

fleish commented 7 months ago

Well, sure we are using git here ... but I'm not running git on my mail servers

frugan-dev commented 7 months ago

@fleish IMHO we should think about what objectively makes sense at a global level, and not what we personally like at a local level. Even indicating the dates in the comments doesn't make much sense, since git takes care of keeping track of them

fleish commented 7 months ago

I get your point of view, but also don't see how alphabetizing makes any more sense at a global level than the current sort method. There are also multiple ways this software gets distributed outside of git (even downloading the zip file from git excludes the actual git back-end data).