search

schwilklab / skyisland-climate

Climate data and code for Sky Island project
2 stars 2 forks source link

Need to wrap ascii grid reading into function #11

Closed dschwilk closed 8 years ago

dschwilk commented 9 years ago

Too much code repetition in random-forest.R right now (https://github.com/schwilklab/skyisland-climate/blob/rfmodels/scripts/random-forest.R#L34). TODO: wrap up the file reading into a function and call once on list of variable names.

hpoulos commented 9 years ago

Totally agreed. I couldn't get the raster package to run unless I renamed the objects to follow the example code for some reason. As I said, it's messy, but I got it to run and provide an output. This was a first stab. I also always name all the variables in the model instead of using ~. so that I can easily remove insignificant predictors directly in the code. Let me know when to pull request and I'll take a look at your changes.