schwittmann / pebble-trello2

Trello app for Pebble. Version 2: C rewrite
BSD 3-Clause "New" or "Revised" License
6 stars 2 forks source link

Add Feature: Hide Cards without a Checklist (and SDK Update) #4

Closed KyleKing closed 3 years ago

KyleKing commented 7 years ago

Hi, if you're interested I modified the repository to display only cards that contain at least one checklist.

If you only want the SDK update, you can just modify the code block in pebble-js-app.js#L266 from:

        if (cardArray.length > 1) {
            data[cards[k].name] = cardArray;
        } else {
            // Otherwise skip the card
            console.log('No properties found for card: '+cards[k].name.toString());
        }

to

        data[cards[k].name] = cardArray;

(Edit: Updated the source code link after the final comment fixes: https://github.com/schwittmann/pebble-trello2/pull/4#issuecomment-322613599)

schwittmann commented 7 years ago

Thanks, will merge once I have tested it :)

KyleKing commented 7 years ago

Awesome! I wasn't sure how active any of the Pebble apps would be anymore. I made a final tweak to fix a few comments

schwittmann commented 7 years ago

I think there is some code missing. MESSAGE_TYPE_NO_CHECKLISTS is set as a type in pebble-js-app.js but never used in pebble-trello2.c. Do you have pending changes there?