schxslt / schxslt-java

Java classes for Schematron validation with SchXslt
MIT License
7 stars 4 forks source link

Possible Java bug in CompilerFactory.java #3

Closed dynarithmic closed 5 years ago

dynarithmic commented 5 years ago

Note: I found this with a SonarQube check on the code.

Here is a possible bug in CompilerFactory.java when checking for a blank string:

if (queryBinding == "") {

A check for a blank string should use queryBinding.isEmpty(), or .equals("") (plus maybe a check for null beforehand).

dmj commented 5 years ago

Thanks for reporting!