schymane / ReSOLUTION

SOLUTIONS for High ReSOLUTION Mass Spectrometry
7 stars 5 forks source link

getMBRecordInfo crashes while sending a custom field_codes list #8

Open tsufz opened 2 years ago

tsufz commented 2 years ago

The submission of a custom field code list crashes getMBRecordInfo:

Error in if (field_codes == "default") { : the condition has length > 1

The reason is that the if query only accepts character vectors of length = 1. The result of the query is FALSE, in the case of a custom field_code list, the result is something like FALSE FALSE FALSE and thus could not be evaluated.

I fixed this and Iwill send a PR.

-- SessionInfo() R version 4.2.1 Patched (2022-06-23 r82518 ucrt) Platform: x86_64-w64-mingw32/x64 (64-bit) Running under: Windows 10 x64 (build 19044)

Matrix products: default

locale: [1] LC_COLLATE=English_United Kingdom.utf8 LC_CTYPE=English_United Kingdom.utf8 LC_MONETARY=English_United Kingdom.utf8 LC_NUMERIC=C
[5] LC_TIME=English_United Kingdom.utf8

attached base packages: [1] grid stats graphics grDevices utils datasets methods base

other attached packages: [1] ReSOLUTION_0.1.10 nontarget_2.2 mgcv_1.8-40 nlme_3.1-158 nontargetData_1.1 mzR_2.30.0 readxl_1.4.0 OrgMassSpecR_0.5-3 RChemMass_0.1.28
[10] httr_1.4.3 rjson_0.2.21 enviPat_2.4 rsvg_2.3.1 curl_4.3.2 rcdk_3.6.0 rcdklibs_2.3 rJava_1.0-6 RMassBank_3.7.1
[19] Rcpp_1.0.8.3