search

sci-visus / OpenVisus

Open Source distribution of the ViSUS capabilities
Other
27 stars 18 forks source link

Add hacked support for cache directory #227

Closed klacansky closed 1 year ago

klacansky commented 1 year ago

Prototype cache directory support until we have the proper API on C++ side.

scrgiorgio commented 1 year ago

mmm this needs more work:

db1=ov.load_dataset(url1,cache_dir=value1)
db2=ov.load_dataset(url2,cache_dir=value2)
access=db1.createAccessforBlockQuery(); # this will get value2

we need something more than an env var here probably.

klacansky commented 1 year ago

Ideally, the optional argument cache_dir would be passed to the C++ LoadDataset. That function would also check if cache_dir is a directory and not a file. If the cache_dir argument is not present, OpenVisus would work as before.

We could use the proposed setDefaultCacheDir in issue #220, at the cost that C++ and Python APIs diverge. I would then modify the load_dataset function to call the setDefaultCacheDir function. I personally think it is better to do it on C++ side, so that code that uses C++ library can benefit too.