Feature/forgot password - Githubissues

sci2zero / TeslaRIS-backend

GNU General Public License v3.0

0 stars 1 forks source link

Feature/forgot password #67

Closed ivanmrsulja closed 9 months ago

ivanmrsulja commented 10 months ago

Description

Implemented "I forgot my password" functionality.

How should this be tested?

There are unit and integration test for everything, but you can test using postman by firstly setting up a mail client, then sending a request to http://localhost:8081/api/user/forgot-password, and after that, sending a request to http://localhost:8081/api/user/reset-password together with the token provided in the email.

Checklist

[x] I have tested these changes locally
[x] I have added tests that cover these changes (if applicable)
[x] I have updated the documentation (if applicable)
[x] I have added or updated the necessary comments in the code

ivanmrsulja commented 10 months ago

@ivanmrsulja thanks. Looks nice. My only comment is about naming submitForgottenPassword method and ForgotPasswordSubmissionDTO class, it looks strange to me.

Maybe rename it to initiatePasswordResetProcess and PasswordResetRequestDTO? What do you think?