search

sciactive / pnotify

Beautiful JavaScript notifications with Web Notifications support.
https://sciactive.com/pnotify/
Apache License 2.0
3.65k stars 513 forks source link

Cut new release to NPM to support webpack #290

Closed sman591 closed 7 years ago

sman591 commented 7 years ago

A very important webpack fix was merged in #268, however a new release hasn't been made.

The diff from version 3.0.0 to now: https://github.com/sciactive/pnotify/compare/3.0.0...master

A new release would be much appreciated!

(temporary solution)

thedotedge commented 7 years ago

👍

codymullins commented 7 years ago

+1

zahedul commented 7 years ago

+1

codymullins commented 7 years ago

@hperrin do you need help with maintaining this repository?

nglelinh commented 7 years ago

+1

hperrin commented 7 years ago

@codymullins, If you're willing, absolutely. I maintain this on my free time, which is scarce today, as I'm working at LinkedIn and running a podcast.

hperrin commented 7 years ago

Although, soon I plan to refactor the entire library to get rid of jQuery as a dependency.

sman591 commented 7 years ago

@hperrin Any way we could get a 3.0.1 release in the meantime before a rewrite? The changes between 3.0.0 and master are relatively small: https://github.com/sciactive/pnotify/compare/3.0.0...master

hperrin commented 7 years ago

Yes. I'll be working on PNotify all day tomorrow, so I'll make a new release then.

codymullins commented 7 years ago

@hperrin I'll start poking through the code and issues to familiarize. Let me know what I can do to help - can see if there's any significant issues reported, how extensively are you planning on refactoring?

hperrin commented 7 years ago

Cody, I won't be refactoring a whole lot, just implementing things that jQuery is used for right now. The functionality should remain the same. Can you send me a DM on Twitter "@sciactive" and we can coordinate?

Everyone else, a new 3.0.1 release is out. It includes a new build system that uses Node instead of Bash, and now creates source maps.

codymullins commented 7 years ago

@hperrin I can't DM you on Twitter it seems: https://support.twitter.com/articles/14606