sciactive / pnotify

Beautiful JavaScript notifications with Web Notifications support.
https://sciactive.com/pnotify/
Apache License 2.0
3.65k stars 513 forks source link

Modal notifications leave empty element in DOM #301

Closed todduk closed 6 years ago

todduk commented 7 years ago

When you create a modal notification and then close it, either by confirming, cancelling or closing, there is an empty element left at the top of the \<body>. <div style="display: none;" class="ui-pnotify-modal-overlay"></div>

Unclear if it should be being reused or deleted, but the issue is also present on the documentation page.

When any type of notif is open and you mouseout all of the left over elements are updated in some way (possibly opacity, can't tell, sorry).

hperrin commented 6 years ago

Ideally, the element should be destroyed when all notices in the modal stack have been closed and recreated if they are opened again.