sciactive / pnotify

Beautiful JavaScript notifications with Web Notifications support.
https://sciactive.com/pnotify/
Apache License 2.0
3.65k stars 514 forks source link

h4 color conflict with bootstrap4 #341

Closed yepeekai closed 5 years ago

yepeekai commented 6 years ago

bootstrap 4 set the color for all headers h1, h2, h3, h4, h5, h6 to headings-color. By default, it is inherit, but we don't use the defaults... PNotify set color on the container div of the h4. So h4 uses the color specified in bootstrap since the rule has precedence over pnotify. Since PNotify tries to use a different color than the default one, I think it should also add the class on the h4 so that it takes precedence over the default h4 color.

hperrin commented 5 years ago

Good catch.