search

sciancio / connectionmanager2

Simple GUI app for Gnome 3 that provides a menu for initiating SSH/Telnet connections
60 stars 45 forks source link

add tabs option for terminator #13

Closed dnotivol closed 12 years ago

dnotivol commented 12 years ago

Hi sciancio,

It's a great extension, and a good point to include terminator as an alternative to native terminal.

Using it I saw it didn't open the connections in tabs when selecting terminator, and I saw in the wiki it's a limitation in the design. In the wiki you say terminator doesn't support tabs, but I'd say it does, at least in the release I'm using (0.95-1 in Ubuntu 11.10).

I was wondering if this feature could be included in a future release. By the way, i just tried to edit the js code, and remove the restriction, and it is working for me. (Not sure if it should be the only change, or if this change can have collateral damages.)

Line 453, before: if ( (this._menu_open_tabs) && (!this._terminator_as_terminal) ) { Line 453, after: if (this._menu_open_tabs) {

Thanks.

dnotivol commented 12 years ago

Sorry for shooting too early. The simple change I proposed doesn't work obviously. It opens the tabs but using gnome-terminal. It would be a nice feature to have in this extensions.

Thanks for your work.

sciancio commented 12 years ago

Hi,

when I have added terminator support, there were some problems with tabs. I have Fedora 16 and terminator 0.96. Terminator FAQ says: "You can start other programs, even in multiple tabs, from the command line. See terminator --help for the syntax. Here's an example that opens a new window with two tabs:

terminator -n "top's tab's title" top -n "another tab title" bash " But the command results in an error. (unkown option -n).

I'll investigate further about tab in terminator and when it works correctly, I'll add it in CM.

sciancio commented 12 years ago

Hi,

terminator supported in CM extension is http://www.tenshu.net/p/terminator.html that doesn't support tab in command line.

The other terminator software (same name! and not supported in CM) is http://software.jessies.org/terminator/ that supports tab in command line.