Closed daroczig closed 11 years ago
Thanks Gergely!!
I will merge your code in the next version of the extension.
On 22/10/2012 21:34, Gergely Daróczi wrote:
LilyTerm: https://github.com/Tetralet/LilyTerm
Please note that this patch does not deal with profiles (although LilyTerm support that with the |-u profile_name| option) and is a really minimal implementation - although works like a charm for me.
Based on this, I am just rather sharing my current code to let others also use connectionmanager with LilyTerm, it should not be merged without minor/major rewrite (BTW I have never coded in Python before).
This pull request may be useful for #25 https://github.com/sciancio/connectionmanager/issues/25 @ sciancio/connectionmanager#25 https://github.com/sciancio/connectionmanager/issues/25
You can merge this Pull Request by running:
git pull https://github.com/daroczig/connectionmanager lilyterm
Or view, comment on, or merge it at:
https://github.com/sciancio/connectionmanager/pull/27
Commit Summary
add: LilyTerm support (rather POC demo instead of a full-blown solution)
File Changes
- M connmgr.py (2)
M terminals.js (76)
Patch Links
- https://github.com/sciancio/connectionmanager/pull/27.patch
- https://github.com/sciancio/connectionmanager/pull/27.diff
— Reply to this email directly or view it on GitHub https://github.com/sciancio/connectionmanager/pull/27.
@sciancio: just be cautious with that :) Please note that this is a rather POC demo.
Closing this, thanks for adding LilyTerm support in SHA: 20a8bb4240fc941cbf2c82c9cd7f896e544691bf
LilyTerm: https://github.com/Tetralet/LilyTerm
Please note that this patch does not deal with profiles (although LilyTerm support that with the
-u profile_name
option) and is a really minimal implementation - although works like a charm for me.Based on this, I am just rather sharing my current code to let others also use connectionmanager with LilyTerm, it should not be merged without minor/major rewrite (BTW I have never coded in Python before).
This pull request may be useful for #25 @ https://github.com/sciancio/connectionmanager/issues/25