Closed morganastra closed 11 years ago
I think a really similar pull request was closed before, that's why I created an AUR package which automatically applies the patch.
Yes, it was. However, there's no need for an Arch-specific patch. With my simple modification, the exact same code will work on both Archlinux and Fedora (and Ubuntu, etc). One major advantage of supporting all distros with the same codebase is that extensions installed through https://extensions.gnome.org/ will always work.
Hi Patrick, Hi Gergely,
thanks for the code. I am installing an archlinux system to check your patch. I am going to release a new version next week.
On 06/12/2012 17:30, Patrick Mullaney wrote:
Yes, it was. However, there's no need for an Arch-specific patch. With my simple modification, the exact same code will work on both Archlinux and Fedora (and Ubuntu, etc). One major advantage of supporting all distros with the same codebase is that extensions installed through https://extensions.gnome.org/ will always work.
— Reply to this email directly or view it on GitHub https://github.com/sciancio/connectionmanager/pull/31#issuecomment-11092497.
Thanks Stefano, and let me know if there's anything else I can help with!
I like to keep things simple too, so I would be also very happy if the patch on AUR would not be required (and simply installing from EGO).
Thanks Patrick and Gergely. Your patch is ok.
The original behavior was to try invoking
python
first, and then invokepython2
if that fails. However, on systems with both Python2 and Python3 installed in parallel wherepython
is an alias forpython3
(like Archlinux), the first invocation withpython
seems to succeed, but the script fails. By simply tryingpython2
first, this case can be handled correctly without breaking it on other systems.