search

sciancio / connectionmanager2

Simple GUI app for Gnome 3 that provides a menu for initiating SSH/Telnet connections
60 stars 45 forks source link

Not compatible with Gnome 3.24.2 #60

Closed TheBigFatTony closed 7 years ago

TheBigFatTony commented 7 years ago

I cannot activate "Connection manager" in Gnome 3.24.2. (Fedora 26) It tells me "error loading extension". If you require any further information, tell me how I can provide it.

omkensey commented 7 years ago

The error is coming from the use of the .quote() method which is not part of the standard and apparently has been removed or disabled in GNOME 3.24. I got it working again by replacing all calls to the method with the JSON.stringify() function (e.g. foo.quote() becomes JSON.stringify(foo)).

I was going to submit a PR, but I see there's already one that includes that as well as several other changes -- #59. So if you delete the extension, download the full tree of that PR and drop it in ~/.local/share/gnome-shell/extensions/connectionmanager2@ciancio.net/, the extension should work again.

TheBigFatTony commented 7 years ago

yep, that fix worked. thank you and keep up the good work!