sciancio / connectionmanager2

Simple GUI app for Gnome 3 that provides a menu for initiating SSH/Telnet connections
60 stars 45 forks source link

Failed to start in Gnome 44 #74

Closed pieska closed 1 year ago

pieska commented 1 year ago

it fails to start in fedora 38 with gnome 44.0:

gnome-shell[1631]: JS ERROR: Extension connectionmanager2@ciancio.net: TypeError: imports.gi.Gtk.IconTheme.get_default is not a function init@/home/pharaoh/.local/share/gnome-shell/extensions/connectionmanager2@ciancio.net/extension.js:351:42 _callExtensionInit@resource:///org/gnome/shell/ui/extensionSystem.js:486:56 async*loadExtension@resource:///org/gnome/shell/ui/extensionSystem.js:394:33 _loadExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:677:24 async*_enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:683:48 _sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:718:20 async*init@resource:///org/gnome/shell/ui/extensionSystem.js:59:14 _initializeUI@resource:///org/gnome/shell/ui/main.js:309:22 start@resource:///org/gnome/shell/ui/main.js:186:5 @resource:///org/gnome/shell/ui/init.js:6:17

erve-cz commented 1 year ago

On Fedora 38


function init(extensionMeta) { extensionPath = extensionMeta.path;

 //let theme = imports.gi.Gtk.IconTheme.get_default();
 //if (theme != null) {
 let theme = imports.gi.St.IconTheme.new();
 if (theme != null) {
             theme.append_search_path(extensionPath);
     }

and in matadata.json :

"shell-version": [ "44.1" ],

pieska commented 1 year ago

thank you, this fixed the issue