search

sciancio / connectionmanager2

Simple GUI app for Gnome 3 that provides a menu for initiating SSH/Telnet connections
60 stars 45 forks source link

failed to load in gnome 45.1 (fedora 39) #75

Open pieska opened 8 months ago

pieska commented 8 months ago

it's broken again. worked in gnome 44 (with fixes),doesn nit load in gnome 45.1:

Nov 07 22:04:37 gnome-shell[1667]: JS ERROR: Extension connectionmanager2@ciancio.net: SyntaxError: import declarations may only appear at top level of a module @ resource:///org/gnome/shell/ui/main.j>

Does anyone knows how to fix it?

xkahn commented 7 months ago

I'm working on the solution for this here: https://github.com/xkahn/connectionmanager2/tree/gnome-45 But it isn't working yet and it's slow going. If anyone else is interested in helping out, I'm accepting help!

pieska commented 7 months ago

I would love to help out, but I know nothing about java script, I'm more a hardware guy. nut you should use my fork https://github.com/pieska/connectionmanager2 to start with, it has all the fixes for gnome 44.

xkahn commented 7 months ago

@pieska Ah ha! This is great. I was missing 6 of those 7 patches. It should speed up the port significantly.

sbadger commented 4 months ago

@xkahn Tried your gnome-45 branch out but I am seeing the following error: Extension connectionmanager2@ciancio.net: SyntaxError: redeclaration of let Me @ file:///home/######/.local/share/gnome-shell/extensions/connectionmanager2@ciancio.net/search.js:35:6

xkahn commented 4 months ago

@sbadger Ah yes.... I got busy and stopped paying attention to this issue. Thanks for the ping. I'll see if I can finish this up.

xkahn commented 4 months ago

@sbadger Huh. I was closer than I thought. I just committed a few changes to the repo. It should work now.

pieska commented 4 months ago

@xkahn Does not work for me in a new fully patched F39 VM but I cannot open an issue at https://github.com/xkahn/connectionmanager2, so here are the errors at startup:

Feb 28 11:56:49 localhost-live gnome-shell[1208]: JS WARNING: [file:///usr/share/gnome-shell/extensions/connectionmanager2@ciancio.net/search.js 128]: unreachable code after return statement
Feb 28 11:56:49 localhost-live gnome-shell[1208]: Extension connectionmanager2@ciancio.net: TypeError: global.logError is not a function

                                                                   Stack trace:
                                                                     _readConf@file:///usr/share/gnome-shell/extensions/connectionmanager2@ciancio.net/extension.js:125:20
                                                                     ConnectionManager@file:///usr/share/gnome-shell/extensions/connectionmanager2@ciancio.net/extension.js:88:14
                                                                     enable@file:///usr/share/gnome-shell/extensions/connectionmanager2@ciancio.net/extension.js:333:19
                                                                     _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:253:38
                                                                     loadExtension@resource:///org/gnome/shell/ui/extensionSystem.js:461:32
                                                                     async*_loadExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:759:24
                                                                     async*_enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:765:48
                                                                     _sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:800:20
                                                                     async*init@resource:///org/gnome/shell/ui/extensionSystem.js:72:14
                                                                     _initializeUI@resource:///org/gnome/shell/ui/main.js:303:22
                                                                     start@resource:///org/gnome/shell/ui/main.js:176:11
                                                                     @resource:///org/gnome/shell/ui/init.js:12:47
                                                                     @resource:///org/gnome/shell/ui/init.js:21:20
xkahn commented 4 months ago

@pieska ...huh. That was a line I hadn't touched. I've changed the error logging to be console.error instead.

sbadger commented 4 months ago

@sbadger Huh. I was closer than I thought. I just committed a few changes to the repo. It should work now.

It is working fully for me on Fedora 39. Thanks for you work!

pieska commented 4 months ago

@sbadger Huh. I was closer than I thought. I just committed a few changes to the repo. It should work now.

It is working fully for me on Fedora 39. Thanks for you work!

confirmed! thank you @xkahn