search

sciapp / gr

GR framework: a graphics library for visualisation applications
Other
327 stars 54 forks source link

Remove that camera rotation and tilt are integer degrees #157

Closed GijsBellaard closed 2 years ago

GijsBellaard commented 2 years ago

Honestly this is just ridiculous. Could this please be changed to floats?

I'm talking about static void setspace(double zmin, double zmax, int rotation, int tilt) in lib/gr/gr.c.

jheinen commented 2 years ago

The question is honestly not very nicely worded. Please use setspace3d, e.g.

setwindow(-1, 1, -1, 1)
setwindow3d(xmin, xmax, ymin, ymax, zmin, zmax)
setspace3d(-rotation, tilt, 30, 0)
GijsBellaard commented 2 years ago

Thanks that works :)

But still... why is setspace in integer degrees?

jheinen commented 2 years ago

... due to compatibility issues with old(er) software

GijsBellaard commented 2 years ago

right...