search

sciapp / gr

GR framework: a graphics library for visualisation applications
Other
329 stars 54 forks source link

Install gksm when building with cmake #188

Open kenhys opened 3 weeks ago

kenhys commented 3 weeks ago

When building with Makefile, gksm will be installed. But when building with cmake, gksm will not be installed.

jheinen commented 3 weeks ago

Thank you for the merge request.

The gksm program is created in the Makefile for historical reasons - we don't actually want to roll it out in the CMake variant. Especially as the patch does not work on all platforms.

We will of course be happy to adopt the corrections concerning the typos. Could you edit the MR in this respect?

Thanks in advance.

kenhys commented 4 days ago

We will of course be happy to adopt the corrections concerning the typos. Could you edit the MR in this respect?

About typo, I've sent it as PR https://github.com/sciapp/gr/pull/187 It was merged but it seems disappeared from develop branch.

kenhys commented 4 days ago

Especially as the patch does not work on all platforms.

Thanks, I'm not tested all, it should be draft PR.