search

sciapp / gr

GR framework: a graphics library for visualisation applications
Other
329 stars 54 forks source link

Missing inqmarkersize in GR #56

Closed tv11 closed 5 years ago

tv11 commented 6 years ago

the inqmarkersize function is currently not available in GR. It would be required to save the current value of markersize to add support to choose the markersize in the python-gr classes PlotCurve and ErrorBar. I attached a patch to add the function and also the patch to python-gr that needs it. patch_inqmarkersize_gr.txt patch_add_markersize_python_gr.txt

jheinen commented 6 years ago

As quick workaround, you could use savestate() and restorestate() for temporary changing attributes. Would this be acceptable for you?

tv11 commented 6 years ago

what would be the preferred solution for the second patch (and in general)? python-gr seems to use the savestate / restorestate mechanism only in the matlab-style api and the inq* functions anywhere else. I'm using my own build of gr anyway so there is no immediate need for a solution, but would like to propose the second patch to python-gr sometime in the future, as it may help others, too.

danielkaiser commented 5 years ago

We are closing this issue due to inactivity. Please reopen the issue and let us know if its cause still persists with the current version of GR.

kojix2 commented 4 years ago

I also found this issue. The current version of GR does not seem to implement inqmarkersize.

danielkaiser commented 4 years ago

The gr_inqmarkersize function is now included in the v0.42.0 release of the GR runtime and the Python wrapper for this function is added to the develop branch and will be included in the next python-gr release.

kojix2 commented 4 years ago

Oh, Thank you for your explanations. :tada: