search

sciapp / python-gr

Python wrapper for the GR framework
https://gr-framework.org
Other
30 stars 8 forks source link

Improve python wheel build #28

Closed bpedersen2 closed 2 years ago

bpedersen2 commented 2 years ago

The wheel does include platform-specific files, but is not marked as such ( gr-...-any.whl).

See https://stackoverflow.com/questions/45150304/how-to-force-a-python-wheel-to-be-platform-specific-when-building-it how make setup.py aware of this to get platfrm-specific wheels.

FlorianRhiem commented 2 years ago

Hello @bpedersen2,

I am somewhat confused, as I am not aware of us distributing wheels for GR. What wheels are you referring to?

bpedersen2 commented 2 years ago

It is correct that currently no wheels are provided by the gr project, but this also affects building those wheels locally ( we use virtualenvs with gr heavily in our CI jobs and have a local mirror of pre-built wheels to speed up setup of those venvs)

bpedersen2 commented 2 years ago

I'll upload a pull request soon.

FlorianRhiem commented 2 years ago

Ah, okay. Currently, while installing GR, the required platform-specific files are downloaded either from github or from gr-framework.org if it's not a stable version or github is unavailable. There are files for:

and these platforms don't cleanly map to the platform names used by wheels, as far as I'm aware. This is part of the reason why we do not provide wheels but instead download the binaries based on the specific system.