Add an option to disable invitations

sciapp / sampledb

Sample and Measurement Metadata Database

MIT License

21 stars 11 forks source link

Closed timhallmann closed 1 month ago

FlorianRhiem commented 1 month ago

Hey @timhallmann, thanks for the PR! It looks good, but I have two minor suggestions:

Change it to SAMPLEDB_DISABLE_USER_INVITATIONS, to avoid any misunderstandings with group invitations
Add an entry to the changelog, e.g. "Allow disabling user invitations with SAMPLEDB_DISABLE_USER_INVITATIONS" or something like that, to help SampleDB administrators notice the new feature

timhallmann commented 1 month ago

Done.

Edit: Also mentioned the options name in the changelog.