search

sciber-io / yubikey-locker

Sciber Yubikey Locker
MIT License
1 stars 0 forks source link

Missing input validation for RemovalOption #86

Closed p4fg closed 2 weeks ago

p4fg commented 2 months ago

The current code will not warn the user if a invalid -l parameter is set. Any mis-spelled value for the RemovalOption will result in RemovalOption.NOTHING being set, without any warning.

dtothelander commented 1 month ago

This is good behavior (from our perspective) as if you fail with your command line arguments in a large deployment you don't want to end up with automatically locking out users that you cannot centrally manage.

We will make sure that the user is told that this happened as you are suggesting and see if we can make it more clear on the expected behavior. Thank you for reporting Peter!