search

scicloj / clay

A REPL-friendly Clojure tool for notebooks and datavis
https://scicloj.github.io/clay/
Eclipse Public License 1.0
132 stars 13 forks source link

minor problem browsing the docs #40

Open blnote opened 9 months ago

blnote commented 9 months ago

Hey, I really like the project! Just a minor issue with the documentation at https://scicloj.github.io/clay (don't know if it is the right place here ?) I find it kind of hard to browse because when pressing the up/down arrow keys it scrolls to the embedded portal-visualization and focuses it - no matter where I am on the page. May be a browser issue (I'm using Brave), but also occurs in Edge.

Further in both browsers and on mobile I find the headers hard to read in dark-mode clay

I'm happy to help if needed, best regards!

daslu commented 9 months ago

@blnote many thanks, this is very helpful.

Yes, Portal is indeed capturing key bindings of the whole page at the moment. Yesterday on a discussion with Portal's creator @djblue, I wondered whether this was actually a usability problem. It helps to know that it is noticable on your side.

Also thanks for noticing the problem with headers in dark-mode, I haven't figured that out yet.

daslu commented 9 months ago

Good news: The font colour problems seem to be caused by the embedded Portal as well. With no Portal viewers embedded, the colours are ok.

daslu commented 9 months ago

Link to Slack #portal discussion: https://clojurians.slack.com/archives/C0185BFLLSE/p1705829969607509

daslu commented 9 months ago

The dark mode problem seems to be solved in version "2-alpha76" (relying on a temporary pre-release build of Portal). The keyboard problem remains for now.