search

scicloj / clojisr

Clojure speaks statistics - a bridge between Clojure to R
https://scicloj.github.io/clojisr/
Eclipse Public License 2.0
150 stars 10 forks source link

Lazy r defs #99

Open behrica opened 4 months ago

behrica commented 4 months ago

got the simple unary / binary functions "r_xxx" working

behrica commented 4 months ago

now as well the str-md

behrica commented 4 months ago

I think I made all "lazy", keeping full functionality. running clj src/clojisr/v1/r.clj does not trigger initialize R any more, so namespace can be required and does not try to connect to R. I made tests for all functions and they keep passing.

genmeblog commented 4 months ago

Wow! You've made a great job! Thanks. I'll take a look at this today.

behrica commented 4 months ago

lates commit https://github.com/scicloj/clojisr/pull/99/commits/c952bed0f66028d1b58b3b84c442b70995ee6895 here fixes as well #96

behrica commented 4 months ago

Where is the code which defines x %% y x %/% y %in% ?

Its mentioned in CHANGELOG, but cannot find it

genmeblog commented 4 months ago

Where is the code which defines x %% y x %/% y %in% ?

Its mentioned in CHANGELOG, but cannot find it

I don't remember precisely, maybe it was done in codegen. I need to verify this.

genmeblog commented 4 months ago

I'll review this today.

behrica commented 1 week ago

@genmeblog any progress on the review of this PR ?

genmeblog commented 1 week ago

Oh, thanks for the reminder. I believe I've tested it locally and everything worked. But it was 4 months ago.