scicloj / kindly

A small library for defining how different kinds of things should be rendered
Eclipse Public License 2.0
25 stars 3 forks source link

Move echarts to kindly from clay #1

Closed dmg46664 closed 11 months ago

dmg46664 commented 2 years ago

I presume that the following defined in clay project should be moved to kindly. https://github.com/scicloj/clay/blob/main/src/scicloj/clay/v1/tool/clerk.clj#L155

Otherwise, if clay breaks for unrelated reasons, then this functionality breaks too. I don't understand why this project doesn't have clerk specific stuff where as clay does....

daslu commented 2 years ago

@dmg46664 thanks, it is a good idea to rethink the division of roles between these two libraries.

Possibly you are right about this, let us discuss soon.

daslu commented 11 months ago

This is fixed in the current Kindly v4 / Clay v2 settings. Thanks, @dmg46664.