scicloj / metamorph.ml

Machine learning functions for metamorph based on machine learning pipelines
Eclipse Public License 2.0
18 stars 3 forks source link

Fix malli schema definitions + evaluation_handler_test.clj #5

Closed respatialized closed 2 years ago

respatialized commented 2 years ago

Hi! I encountered the same issue at #4, so I decided to work up a quick PR to fix it. The changes needed to the malli schemas to fix compatibility with the latest version (v0.8.4) were relatively small and straightforward - just putting each k/v pair in its own vector. I also bumped the malli version and fixed one of the tests by referring to the ml_test.clj file in the repo rather than the local path.

I tested this locally with clojure -Mtest:runner and the suite passes. Please let me know if you need me to make any revisions!

behrica commented 2 years ago

Thanks for the PR !