scicloj / noj

A clojure framework for data science
Eclipse Public License 1.0
35 stars 4 forks source link

small fixes to automl notebook #29

Open behrica opened 1 day ago

daslu commented 10 hours ago

Hi @behrica, nice additions.

I think this PR goes beyond small fixes and requires discussion.

I don't think it makes sense to add dependencies to the :dev alias, except for tooling (e.g., Clay).

The goal of the tutorials is to test and document the integration of the libraries in the main deps. If we want scicloj.ml.smile and sklearn-clj in the tutorials, we need to decide whether they are part of Noj.

sklearn-clj seems harmless. scicloj.ml.smile may be ok but needs testing.

But let us discuss this at Zulip and then have a dedicated PR to add the relevant libraries to the main deps?