search

scicloj / notespace

using your namespace as a notebook
Eclipse Public License 2.0
148 stars 10 forks source link

Listening port of gorilla-notebook should be changable #27

Closed behrica closed 3 years ago

behrica commented 3 years ago

This function should have it as parameter: https://github.com/scicloj/notespace/blob/ab2068146ac6e2e86175a8c7b045e057e9827c4f/src/notespace/renderers/gorilla_notes.clj#L19

Requires change in: https://github.com/scicloj/gorilla-notes/blob/347223a899eeba67b1ace4198faef929dc646db1/src/gorilla_notes/core.clj#L48

Without this, tests can not start a new instance without having port conflicts. In any case, it is good practice to have it configurable, so users can eventually adapt it to their network settings.

daslu commented 3 years ago

Sounds good.

Would you like to make this change?

I can also do it, probably tomorrow.

behrica commented 3 years ago

I think this is done.