search

scicloj / scicloj-data-science-handbook

Clojure data science handbook - journal style examples of data science
https://scicloj.github.io/scicloj-data-science-handbook/
35 stars 3 forks source link

typo in use of tablecloth/drop-missing? #4

Closed daslu closed 3 years ago

daslu commented 3 years ago

Hi @kimim !

Looking at your wonderful work on chapter 3, I ran into this:

https://github.com/scicloj/scicloj-data-science-handbook/blob/8109e9dd9ab7e0037e3968ce4753665c56a1d67e/src/scicloj/03_data_manipulation/04_missing_values.clj#L172

(tablecloth/drop-missing DS :A)

I'm not sure what was supposed to be here. This does not work, as DS does not have an :A column. Probably a typo?

kimim commented 3 years ago

The code is partially complete, when I am thinking the relationship between NaN and nil. Now I've fix the broken. Thanks.

daslu commented 3 years ago

Thanks, @kimim !