Open st opened 1 year ago
Thanks for spotting this. In practice here https://github.com/scicloj/scicloj.ml-tutorials/blob/7cf7af0404643e589138a87f21edf83d13a56532/src/scicloj/ml/titanic.clj#L260
we only get a single evaluation result back, the best. This is default behaviour of function evaluate-pipelines
.
So sorting and reverting of a sequence of length one is not needed.
I will adapt the code accordingly and commit soon.
Thanks !
Hello,
This line sorts by the key
:mean
in a thread-last operator. https://github.com/scicloj/scicloj.ml-tutorials/blob/7cf7af0404643e589138a87f21edf83d13a56532/src/scicloj/ml/titanic.clj#L267But the given sequence contains maps keyed by
:model :metric and :fit-ctx
Isn't the sort useless? Shouldn't we use:metric
instead?