scicloj / tablecloth.time

Tools for the processing and manipulation of time-series data in Clojure.
Other
18 stars 1 forks source link

Add action to run tests on PRs #18

Closed ezmiller closed 3 years ago

ezmiller commented 3 years ago

Goal

Add some automated tests and linting to be run on pull requests. Why? This can help build a common reference point about code failures and code style.

Implementation

This PR uses github actions that makes running such tests / linters quite easy. I added two different actions. One for linting and one for tests.

The linting action runs two linters

We can always modify and customize these linting tools as we see fit, but they'll help us converge on a common style that also reflects the community's preferences.

How does it work?

Basically when you open a PR the tests / and linters will run. They show up at the bottom of the PR page (i.e. this type of page), and look like this:

image

You can look at the logs of these actions, i.e. this is the last run of the tests on this PR.

ezmiller commented 3 years ago

@rsiddharthan thank you for the review!