scicloj / tablecloth.time

Tools for the processing and manipulation of time-series data in Clojure.
Other
18 stars 1 forks source link

Add type hints to prevent reflection #3

Closed ezmiller closed 3 years ago

ezmiller commented 3 years ago

Goal / Purpose

Per @daslu 's suggestion on #2 , it's a good idea to add type hints to avoid java reflection warnings.

Solution

Activates reflection warnings and adds type hints where needed. One challenging fn to type was the make-index function. I had to ask a question in stackoverflow in the end to understand how to type it! (See here)

daslu commented 3 years ago

Great!