scicloj / tablecloth.time

Tools for the processing and manipulation of time-series data in Clojure.
Other
18 stars 1 forks source link

Adjust slice to use the new index-structure in tech.ml.dataset #31

Closed ezmiller closed 3 years ago

ezmiller commented 3 years ago

Goal / Problem

Adjust the slice method to use the new index-structure in tech.ml.dataset added by https://github.com/techascent/tech.ml.dataset/pull/214.

Proposed Solution

Turns out the main method we needed to adjust here is slice. Rolling window doesn't use the index directly, but uses slice. So I adjusted slice to use the new index.

The adjustment works as follows:

Some other stuff in this PR:

Work remaining

Open Questions

ezmiller commented 3 years ago

@cnuernber no need for you to take a look here, but flagging you just in case you are curious how we've taken up the tmd index structure so far...