Closed ezmiller closed 2 years ago
After chatting with @rsiddharthan, we decide to make two changes:
:also-group-by
=> :categories
adjust-interval
=> adjust-frequency
.Based on this still unfinished conversation with @rsiddharthan, I changed adjust-frequency
to return an ungrouped dataset, unless the user overrides that behavior. This undoes the need for the include-columns
argument that we were discussing. That said this conversation was unfinished and I hadn't grokked fully what @rsiddharthan was saying. Merging now anyway because lots of time has passed and I think this is a reasonable approach for now. We can always change course later.
Goal / Problem
The
adjust-interval
function had an API that was designed for when we were anticipating not knowing yet how we would get the index. We know that now because we have the index on the column in tmd.Proposed Solution
This PR does the following to the adjust-interval API:
get-column-name-or-error
fn added in #45;:also-group-by
in lieu of us supporting the idea of keys officially (#44);So usage now is like this: