search

scicloj / tablecloth.time

Tools for the processing and manipulation of time-series data in Clojure.
Other
18 stars 1 forks source link

refactor rolling-window #50

Closed rsiddharthan closed 2 years ago

rsiddharthan commented 3 years ago

Goal / Problem

Corrections to rolling window

Proposed Solution

  1. renaming len argument as window-size
  2. dropping index-column as an argument, and inferring it from the dataset

Work remaining

Open Questions

There is a open question on performance on large datasets which will be addressed in a separate PR

ezmiller commented 3 years ago

@rsiddharthan I think I will have time to review this a bit later on today.

ezmiller commented 2 years ago

@rsiddharthan long time! How are you? This PR looks like it's ready to go in and we just forgot to merge, so putting it in. Also I think I figured out the performance issues, it was probably related to the index structure, and a mistake I made that caused a performance bottleneck, fixed here: https://github.com/techascent/tech.ml.dataset/pull/278