search

scicloj / tablecloth

Dataset manipulation library built on the top of tech.ml.dataset
https://scicloj.github.io/tablecloth
MIT License
302 stars 27 forks source link

tech.ml.datatype mentioned in the doc #102

Closed daslu closed 1 year ago

daslu commented 1 year ago

https://github.com/scicloj/tablecloth/blob/1e9c8d88c46cdf4492f8fd0e219b4f6af94886a9/docs/index.Rmd#L138

tech.datatype is not active anymore.

It'd make more sense to mention either tech.ml.dataset or dtype-next here.

genmeblog commented 1 year ago

Thanks Daniel. Can you make a PR or update directly? I will refresh docs and publish then.

adham-omran commented 1 year ago

The Columns section makes a similar mention, should this mention be removed?

https://github.com/scicloj/tablecloth/blob/ee091ed8afab3a3d52371c2234a4aa65e21214ec/docs/index.Rmd#L875

Becomes Column is a special tech.ml.dataset structure. For our purposes we cat treat columns as typed and named sequence bound to particular dataset.

I can make a PR for this.

genmeblog commented 1 year ago

Thanks for spotting it. Yes, please, PR welcome!