scicloj / tablecloth

Dataset manipulation library built on the top of tech.ml.dataset
https://scicloj.github.io/tablecloth
MIT License
302 stars 27 forks source link

Docs Typo #2

Closed wongjoel closed 4 years ago

wongjoel commented 4 years ago

There's a typo in the docs for selecting rows. It says:

Select fourth row

(api/select-rows DS 4)

But the code actually selects the fifth row, since the selection is zero indexed. (I noticed because I just got caught out on if the selection is zero-indexed or one-indexed)

I would submit a PR, but not sure which file is the source for the docs.

Thanks for all the work, I've been enjoying reading through the docs and seeing the design of this api (I hadn't seen Dplyr before this)

genmeblog commented 4 years ago

Thanks for catching this. The code for docs is in the RMarkdown (https://github.com/scicloj/tablecloth/blob/master/docs/index.Rmd#L1294) file. I render documentation in R calling rmarkdown::render("docs/index.Rmd","all")

Don't bother with it, I'll fix it soon.

genmeblog commented 4 years ago

fixed in pre-alpha9 (will be deployed soon).