scicloj / tablecloth

Dataset manipulation library built on the top of tech.ml.dataset
https://scicloj.github.io/tablecloth
MIT License
303 stars 27 forks source link

print-dataset with options now returns a string #98

Closed otfrom closed 7 months ago

otfrom commented 1 year ago

Was side effecting via println

genmeblog commented 7 months ago

The print here is intentional. It's a printing function. Do you remember why did you want to remove println in the second case?

otfrom commented 7 months ago

I think I just misread the 1 arity code. I think this is my mistake. I'm happy to close it (and I've not bumped into it in ages and don't remember why I suggested the change).

genmeblog commented 7 months ago

I remember we've discussed this but what was the conclusion? idk... :) Anyway - there are two functions one creates string and one prints to the out. Should be ok for all the cases. Closing it.