search

scidash / neuronunit

A package for data-driven validation of neuron and ion channel models using SciUnit
http://neuronunit.scidash.org
38 stars 24 forks source link

rescale needed in backends line 472 #121

Closed russelljjarvis closed 6 years ago

russelljjarvis commented 6 years ago

If line 472 of backends is made to read:

results['t'] = [float(x/1000.0) for x in copy.copy(self.neuron.h.v_time.to_python())]

Rather than:

results['t'] = [float(x) for x in copy.copy(self.neuron.h.v_time.to_python())]

as it currently stands, time constant tests and related tests will have better predictive power. Without rescaling by 1000.0 sciunit/quantities believes that NEURON units are in seconds, rather than milli seconds.

https://github.com/scidash/neuronunit/blob/dev/neuronunit/models/backends.py#L472

russelljjarvis commented 6 years ago

Closed, as provided simple fix.