search

scidash / neuronunit

A package for data-driven validation of neuron and ion channel models using SciUnit
http://neuronunit.scidash.org
38 stars 24 forks source link

Just seeking to merge the file neuronunit/tests/dynamics.py #169

Closed russelljjarvis closed 6 years ago

russelljjarvis commented 6 years ago

I will make a pull request for neuronunit -b dev, as I think that integrating my contributions to the file neuronunit/tests/dynamics.py (ISITest, and CVTest) will be the neatest way to get these tests working in the MuscleModel notebook (given that your latest Dockerimage uses a more standard base for NU).

rgerkin commented 6 years ago

I will need to spend more time later this month to review it all before merging.

In the mean time, feel free to just fork openworm/tests and make your fork's Dockerfile point to whatever fork/branch of NeuronUnit you are using, so that it can use your new tests. I will probably end up using that fork as well, or just make the main fork of openworm/tests point to your NeuronUnit branch, too, for now.

russelljjarvis commented 6 years ago

Yes will do.