Open russelljjarvis opened 6 years ago
"united" and "nonunited" refer to whether they have units or not (although it also looks like the more common meaning of "not divided", so sorry for the possible confusion. The "united" keys are checked to make sure they are instances from the quantities package, and that they have the units that the test requires (the test class's units attribute). "nonunited" keys are checked to make sure they are not from quantities, and that they are dimensionless.
The base class's validate_observation
here implements all of this, and is general enough to validate observations in most of the derived tests. However, some other tests may need additional validation, so their validate_observation
methods can call the base class's one via super
and also implement additional validation of the observation.
@rgerkin
ISI and CV test need to override
VMTests.validate_observation
method, but I need to learn whatunited_keys
,nonunited_keys
actually mean.