search

scidash / neuronunit

A package for data-driven validation of neuron and ion channel models using SciUnit
http://neuronunit.scidash.org
38 stars 24 forks source link

NU test.protocol should be flat or more predictable to traverse. #243

Open russelljjarvis opened 4 years ago

russelljjarvis commented 4 years ago

It could be possible to have a stimulation_type key at the same level as other keys.

Examples:

test.protocol['Stimulation_Type'] = str('ramp')
test.protocol['PEAK_AMP'] = 1500*qt.ms
test.protocol['DELAY'] = 500*qt.ms
test.protocol['DURATION'] = 1000*qt.ms

The protocol data type could also its own class that inherits from dictionary. Then the protocol type becomes a class attribute not a dictionary key.

test.protocol.name = str('ramp') # Not even a dictionary key.

One major goal of the test protocol dictionary redesign is to do away with the aliased sub-dictionary 'injected_square_current' that currently inhabits test.protocol.