search

scidash / neuronunit

A package for data-driven validation of neuron and ion channel models using SciUnit
http://neuronunit.scidash.org
38 stars 24 forks source link

Unit tests with arguments #70

Closed rgerkin closed 6 years ago

rgerkin commented 7 years ago

@russelljjarvis When I try to run your unit tests, I get errors like: 

======================================================================
ERROR: test_build_single (unit_test.showcase_tests.OptimizationTestCase)
----------------------------------------------------------------------
TypeError: test_build_single() missing 1 required positional argument: 'rh_value'

======================================================================
ERROR: test_main (unit_test.showcase_tests.OptimizationTestCase)
----------------------------------------------------------------------
TypeError: test_main() missing 1 required positional argument: 'ind'

----------------------------------------------------------------------

Ignore for now that they are in a different location. The main concern is that they take arguments (like rh_value and ind) but I don't see how they are supposed to get these arguments passed to them. Was this just a placeholder for unit tests that you planned to finish later, or is there some way that these arguments were getting passed when you ran them with python -m unittest?

russelljjarvis commented 7 years ago

Yes I planned to finish those unit tests later. I never finished them.

rgerkin commented 7 years ago

@russelljjarvis I think this has been taken care of, right?

rgerkin commented 6 years ago

@russelljjarvis Did you finish them?